fix: avoid try_clone in net_connect to fix Windows DNS resolution - #69
Merged
Conversation
…orruption Signed-off-by: danbugs <danilochiarlone@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR updates host-proxied networking to avoid cloning sockets during net_connect, addressing Windows DNS resolution failures caused by cloned socket handles leaving the original socket in non-blocking mode.
Changes:
- Replaces the
try_clone()pattern inhandle_net_connectwith direct use of the socket from the socket table. - Holds the socket table lock while calling
connect_timeout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Linux Benchmarks
Details
| Benchmark suite | Current: ac8fd6f | Previous: 52a28ce | Ratio |
|---|---|---|---|
hello_world (median) |
20 ms |
20 ms |
1 |
pandas (median) |
110 ms |
100 ms |
1.10 |
density (per VM) |
7 MB |
7 MB |
1 |
snapshot (disk) |
385 MiB |
385 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Windows Benchmarks
Details
| Benchmark suite | Current: ac8fd6f | Previous: 52a28ce | Ratio |
|---|---|---|---|
hello_world (median) |
294 ms |
301 ms |
0.98 |
pandas (median) |
1030 ms |
966 ms |
1.07 |
density (per VM) |
6 MB |
6 MB |
1 |
snapshot (disk) |
392 MiB |
392 MiB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try_clone()+ drop pattern fromhandle_net_connect, callingconnect_timeoutdirectly on the socket while holding the table lockconnect_timeoutinternally toggles non-blocking mode on the socket. When called on a cloned handle (viatry_clone/WSADuplicateSocket), dropping the clone after the call appears to leave the original socket in non-blocking mode on Windows. Subsequentrecvfromfor DNS queries then returns immediately withEWOULDBLOCKinstead of blocking for the response, causing "Temporary failure in name resolution"connect_timeoutis safe because guest dispatch is single-threaded — no other thread contends for the socket table during a callruntime-test-windows (networking-py, urllib_get)test that has been consistently failing since the socket timeout changes landedTest plan
cargo test --libpasses (57 tests)cargo clippycleancargo fmtcleanruntime-test-windows (networking-py, urllib_get)should now pass